Linus Torvalds writes: (Summary) wrote:
So?
So?
It's not going to happen, because you're not going to give garbage parameters.
parameters.
Why would you add a BUG_ON() for something that cannot happen? rhashtable_init() won't initialize the pointers, and we'll get a NULL pointer dereference.
we'll get a NULL pointer dereference.
And hey, we'll probably get it later during boot, once the system is actually up and running, and that NULL pointer dereference might even get logged in the system logs now because the machine booted successfully, and mnaybe it will even get sent to a distro and debugged.
[...]
validations[...]
and rhashtable_init() can return -EINVAL.So?
So?
It's not going to happen, because you're not going to give garbage parameters.
parameters.
Why would you add a BUG_ON() for something that cannot happen? rhashtable_init() won't initialize the pointers, and we'll get a NULL pointer dereference.
we'll get a NULL pointer dereference.
And hey, we'll probably get it later during boot, once the system is actually up and running, and that NULL pointer dereference might even get logged in the system logs now because the machine booted successfully, and mnaybe it will even get sent to a distro and debugged.