Re: VLA removal (was Re: [RFC 2/2] lustre: use VLA_SAFE)
Linus Torvalds writes: (Summary) It generates much more code, and much _slower_ code (and more fragile code), than just using a fixed key size would have done. key size would have done. Ok, so...
View ArticleRe: [PATCH] vsprintf: Make "null" pointer dereference more robust
Linus Torvalds writes: (Summary) We'll still take the fauly, still do vmalloc fault filling, still do a *lot* of potentially really complicated things. complicated things. Guys, stop this idiocy. They...
View ArticleRe: Simplifying our RCU models
Linus Torvalds writes: (Summary) wrote:[...] board with changing these various names? I really would prefer to not see massive re-naming unless there is a really good reason for it. really good reason...
View ArticleRe: [PATCH] x86/vsyscall/64: Drop "native" vsyscalls
Linus Torvalds writes: On Wed, Mar 7, 2018 at 11:12 AM, Andy Lutomirski <luto@kernel.org> wrote: [...] years, and nothing has gone wrong. Delete it. Ack. Ack. I guess we';ll hear if anybody might...
View ArticleRe: Invalid /proc//fd/{0,1,2} symlinks with TIOCGPTPEER
Linus Torvalds writes: (Summary) Why are you using a bind mount in the first place? Right now path_pts() just does ret = path_parent_directory(path); ret = path_parent_directory(path); and that simply...
View ArticleRe: [PATCH 5/9] x86/dumpstack: Improve opcodes dumping in the Code ...
Linus Torvalds writes: On Wed, Mar 7, 2018 at 5:25 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote: [...] least, reduce its possible range to a reasonable max?) Ack. Just limit it to 64 bytes max...
View ArticleRe: [PATCH] docs: clarify security-bugs disclosure policy
Linus Torvalds writes: (Summary) We also don't explicitly disclose the discussion of the patches or the report, although part of it mayt obviously become more or less public for other reasons. or less...
View ArticleRe: [PATCH] [v2] docs: clarify security-bugs disclosure policy
Linus Torvalds writes: That patch looks fine to me, avoiding any terms that might be misunderstood, and being pretty straightforward. misunderstood, and being pretty straightforward. I'm guessing this...
View ArticleRe: [PATCH] vsprintf: Make "null" pointer dereference more robust
Linus Torvalds writes: (Summary) It _does_ affect plain %p. You're correct that it doesn't affect %px and %pK, since those never printed out (null) in the first place. printed out (null) in the first...
View ArticleRe: [PATCH] vsprintf: Make "null" pointer dereference more robust
Linus Torvalds writes: (Summary) wrote:[...] It not only affects %p, but it also affects %pS and friends (sSfFB), Looking around at the x86 panic thing, %p doesn't matter that much, but %p[sSfFB]...
View ArticleRe: [PATCH 5/9] x86/dumpstack: Improve opcodes dumping in the Code ...
Linus Torvalds writes: (Summary) wrote: [...] + unsigned int code_prologue = OPCODE_BUFSIZE * 43 / OPCODE_BUFSIZE; Heh. Heh. That's a very odd way of writing "43". That's a very odd way of writing...
View ArticleRe: [PATCH net-next] modules: allow modprobe load regular elf binaries
Linus Torvalds writes: (Summary) For all we know, people run modprobe with CAP_SYS_MODULE only, since that is obviously the only capability it needs. that is obviously the only capability it needs....
View ArticleRe: [PATCH v1] devpts: resolve devpts bind-mounts
Linus Torvalds writes: (Summary) wrote:[...] dput(path.dentry); why did you duplicate the devpts_ptmx_path() and then do that odd error handling? error handling?We only go into that "if()" statement if...
View ArticleRe: [PATCH] staging: vchiq_arm: Clear VLA warning
Linus Torvalds writes: (Summary) On Fri, Mar 9, 2018 at 10:35 AM, Kees Cook <keescook@chromium.org> wrote: [...] seems like a raw "64" for the array size can be used instead. That's 768 bytes of...
View ArticleRe: [PATCH net-next] modules: allow modprobe load regular elf binaries
Linus Torvalds writes: (Summary) So there's a huge big honking gap between the two. So there's a huge big honking gap between the two. Also, the second part of my suggestion was to be entirely...
View ArticleRe: [PATCH net-next] modules: allow modprobe load regular elf binaries
Linus Torvalds writes: (Summary) On Fri, Mar 9, 2018 at 10:48 AM, Andy Lutomirski <luto@amacapital.net> wrote:[...] ei already has this working for umh.[...] kernel-internal tmpfs file, execveat...
View ArticleRe: [PATCH] vsprintf: Make "null" pointer dereference more robust
Linus Torvalds writes: (Summary) wrote: [...] + pointer address otherwise This is still fundamentally completely wrong. This is still fundamentally completely wrong. It never prints "pointer address",...
View ArticleRe: [PATCH net-next] modules: allow modprobe load regular elf binaries
Linus Torvalds writes: (Summary) On Fri, Mar 9, 2018 at 10:57 AM, David Miller <davem@davemloft.net> The current patch is *broken* because it doesn't handle it. Really. Think of it this way - you...
View ArticleRe: [PATCH] exec: Set file unwritable before LSM check
Linus Torvalds writes: On Fri, Mar 9, 2018 at 11:07 AM, Kees Cook <keescook@chromium.org> wrote: [...] LSM verification and the actual contents of the file later. Can we please not add random...
View ArticleRe: [PATCH net-next] modules: allow modprobe load regular elf binaries
Linus Torvalds writes: (Summary) It's also "is it actually up and running". and running". The rule for "request_module()" (for a real module) has been that it returns when the module is actually alive...
View Article