Re: Hashed pointer issues
Linus Torvalds writes: (Summary) (Untested.) Looks workable. Looks workable.[...] + } Small tweak: you should check the return value of get_random_bytes_arch(), because in theory it can fail. because...
View ArticleRe: Hashed pointer issues
Linus Torvalds writes: (Summary) On Mon, Apr 30, 2018 at 12:16 PM Kees Cook <keescook@chromium.org> wrote: On Mon, Apr 30, 2018 at 12:16 PM Kees Cook <keescook@chromium.org> But if there...
View ArticleRe: Hashed pointer issues
Linus Torvalds writes: (Summary) I think it's fine for this kind of "initialize hashing state" thing, but I would hate for somebody to actually use "get_random_bytes_arch()" as an actual source of...
View ArticleRe: Suboptimal inline heuristics due to non-code sections
Linus Torvalds writes: (Summary) On Tue, May 1, 2018 at 6:40 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote: On Tue, May 1, 2018 at 6:40 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote: [...]...
View ArticleRe: INFO: task hung in wb_shutdown (2)
Linus Torvalds writes: (Summary) wrote:[...] but[...] would be[...] to apply this patch upstream and test whether the problem is solved. Looks ok to me, except: Looks ok to me, except:[...] +...
View ArticleRe: Suboptimal inline heuristics due to non-code sections
Linus Torvalds writes: On Tue, May 1, 2018 at 9:39 AM Nadav Amit <namit@vmware.com> wrote: On Tue, May 1, 2018 at 9:39 AM Nadav Amit <namit@vmware.com> wrote: [...] Would it be reasonable...
View ArticleRe: Suboptimal inline heuristics due to non-code sections
Linus Torvalds writes: (Summary) On Tue, May 1, 2018 at 9:46 AM Nadav Amit <namit@vmware.com> From the gcc docs: From the gcc docs: Some targets require that GCC track the size of each...
View ArticleRe: [v4.17-rcx] Lost IBPB, IBRS_FW support for spectre_v2 mitigation.
Linus Torvalds writes: (Summary) wrote: [...] fix it. So I do think that the original patch is buggy. So I do think that the original patch is buggy. What I think *may* be going on is: What I think...
View ArticleRe: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter()
Linus Torvalds writes: (Summary) On Tue, May 1, 2018 at 1:55 PM Dan Williams <dan.j.williams@intel.com> wrote: wrote:[...] path. How about just changing the rules, and go the old "Don't do that...
View ArticleRe: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter()
Linus Torvalds writes: (Summary) - for a user access the IO error flag potentially causes a SIGBUS as you mention, but even there it's not 100% clear that's necessarily possible or a good idea (I'm...
View ArticleRe: [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option
Linus Torvalds writes: (Summary) On Tue, May 1, 2018 at 4:34 PM Tobin C. wrote: On Tue, May 1, 2018 at 4:34 PM Tobin C. I think with your fixes to get_random_bytes_arch(), it's perfectly fine to use on...
View ArticleRe: [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option
Linus Torvalds writes: (Summary) On Tue, May 1, 2018 at 6:45 PM Steven Rostedt <rostedt@goodmis.org> wrote: On Tue, May 1, 2018 at 6:45 PM Steven Rostedt <rostedt@goodmis.org> wrote: [...]...
View ArticleRe: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter()
Linus Torvalds writes: (Summary) On Tue, May 1, 2018 at 7:26 PM Dan Williams <dan.j.williams@intel.com> Why not just unmap the page and remap a new page in its place? Meaning that it needs...
View ArticleRe: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter()
Linus Torvalds writes: (Summary) I'm not talking page cache indirection. I'm not talking page cache indirection. I'm talking literally mapping a different page into the kernel virtual address space...
View ArticleRe: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter()
Linus Torvalds writes: (Summary) Ablout half of the lines in the patch set comes from that thing. comes from that thing. Is anybody seriously going to use pmem with some in-order chip that can't even...
View ArticleRe: [PATCH 0/6] use memcpy_mcsafe() for copy_to_iter()
Linus Torvalds writes: (Summary) But there's a big gap between "just use 'rep movs' and 'do some cacheline unrollong'". unrollong'". Why isn't it just doing a simple word-at-a-time loop and letting the...
View ArticleRe: [PATCH 5/6 resend] statfs: add ST_SLAVE
Linus Torvalds writes: No explanation, no nothing? No explanation, no nothing? NAK. NAK. Linus Linus Linus
View ArticleRe: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct
Linus Torvalds writes: (Summary) We should not do a stupid divide, because we damn well know that it is NOT VALID to allocate arrays that have hundreds of fthousands of elements, or where the size of...
View ArticleRe: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct
Linus Torvalds writes: (Summary) [...] I find your faith in the size of structs in the kernel touching ;-) I *really* hope some of those examples of yours aren't allocated with kmalloc using this...
View ArticleRe: [RFC] Removal of CONFIG_HAVE_UNDERSCORE_SYMBOL_PREFIX
Linus Torvalds writes: (Summary) On Sat, May 5, 2018 at 12:17 AM Masahiro Yamada < Let's not keep legacy stuff that complicates things around unless necessary. unless necessary. Even if there might...
View Article